Saturday, April 27, 2013

Please do Code reviews

I am not talking about once a moth get together to review "some" code and have your senior people taking about the sex of the angels. What I mean is:

"Please DO peer code reviews before accepting any code in your source repository. Review every single line that gets into your repository".

Forget about that inner voice that is telling you:

* It is a duplication of effort
* My engineers know their job, they don't need "help"
* I know my job
* bla bla bla

Pre-commit code reviews will improve the quality of your code beyond the limits of your imagination. You'll have your engineers thinking twice before submitting a review, because they know what other engineers will be looking for. All in all your engineers will not fall into the temptation of submitting for review half baked not fully tested code. The style of your team will get more homogeneous over time, junior people will pick up patterns and good practices super quick, and you will all be a happy successful family.

The best tool I've used so far is review board, but wikipedia's code review article is a good starting point.

Please Do Code Reviews.